From: Jonas Dreßler <verdre@v0yd.nl>
Date: Mon, 3 Aug 2020 19:47:42 +0000 (+0200)
Subject: appDisplay: Return false in acceptDrop when not accepting the drop
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~684^2^2~70
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=b83c93ad62a73a851a88c8f83b48fdce93ad9f80;p=gnome-shell.git

appDisplay: Return false in acceptDrop when not accepting the drop

Fix what is probably a copy-paste error and return false instead of a
CONTINUE DragMotionResult which is only meant for dragMotion events, not
drop events. This makes sure we don't create a folder when dropping an
app over the drag leeways of another icon.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1389
---

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 861db5d5a..1c25dfe39 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -1541,7 +1541,7 @@ class AppViewItem extends St.Button {
             return false;
 
         if (this._withinLeeways(x))
-            return DND.DragMotionResult.CONTINUE;
+            return false;
 
         return true;
     }